🦋 Changeset detected

Latest commit: 63fcf6f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Hmm, I'm not sure about this. This function is used for other things than just checking for http paths. I assume that adding this check makes it so it report that width and height are needed? I think it'd perhaps be a better option to add an error for this specific case.

@Princesseuh no, the check is for showing the user the correct error when inferSize is being used on a local image. the original error shown in the issue did not come from Astro, but was bubbled up by fetch as it's not provided a valid URL.

if I understand the code correctly, the check that triggers the fetch call is this:

so if you think that the check should not be in the isRemoteImage function, I would move it to this if block instead

Yes, I understand the goal. However the isRemoteImage function is used in other parts of the code than just this specific check. What your change does is invisibly ignore inferSize when the image is not an actual URL, but I think it'd produce a better experience if we instead had an error that would tell the user explicitly that inferSize cannot be used with images inpublic

I have checked if the desired error (which I guess is the one in the screenshot) is displayed with this change by adapting one of the examples (a good place would be the about page in the portfolio example)

this is the code that triggered this error:

@Princesseuh I moved the check for isRemotePath to where I think it should fit if it should not be added to the isRemoteImage check. Would this meet your expectations or should I create a new error?

I think this is better! Ultimately, we'd probably want it done completely differently, but that's something to think through outside of this PR. Thank you!